Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21368: /trunk/epan/dissectors/ /trunk/epan/dissectors/:

[Richard van der Hoff <richardv@xxxxxxxxxxxxx>]

Guy Harris wrote:
> Richard van der Hoff wrote:
> > Unfortunately, this broke the windows build, by adding a dependency on 
> > zlib.h in packet-ssl-utils.h. I'm moving the offending structure into 
> > packet-ssl-utils.c, since it's only accessed there.
> >
> > The alternative is to find everything which might include 
> > packet-ssl-utils.h, and compile with $(ZLIB_CFLAGS) - but it seems silly 
> > to clutter the packet-ssl-utils.h interface any more than it already is.
>
> I'd say the only thing that should be in a header file would be 
> declarations and definitions that are actually used by one or more other 
> files.  Any structure used only internally in a module belong in the .c 
> file for the module, not its .h file.

Quite so.

It turns out that this commit also broke the Linux buildbot: it didn't 
compile when HAVE_LIBGNUTLS was false - now fixed.

I've also taken the opportunity to clean up a number of warnings here.