Wireshark-dev: Re: [Wireshark-dev] JXTA dissector memory leak?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Andrej Mikus <wireshark-dev@xxxxxxxx>
Date: Thu, 29 Mar 2007 02:21:21 +0200
On Wed, 28.Mar.07 16:41:59 -0700, Stephen Fisher wrote:
> The dissector file packet-jxta.c has a comment saying that an allocation 
> is a memory leak:
> 
>     if (NULL != found_addr) {
> 	found_addr->type = AT_URI;
> 	found_addr->len = strlen(*current_token);
> 	/* FIXME 20050605 bondolo THIS ALLOCATION IS A MEMORY LEAK! */
> 	found_addr->data = g_strdup(*current_token);
>     }
> 
> Anyone familiar enough with this dissector to fix it easily?

Should be enough just to change g_strdup to ep_strdup or se_strdup.
See README.malloc for more details.

Andrej