Wireshark-dev: Re: [Wireshark-dev] (Fwd) Re: Patch to AMQP dissector
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Martin Sustrik <sustrik@xxxxxxxxxx>
Date: Wed, 28 Mar 2007 14:23:37 +0200
Ronnie,


Why do you change all function argumentns to use _U_ ?

_U_ is only used to mark a parameter as unused so that the compiler
will not emit any warnings "parameter foo is never used".

You only set this _U_ for arguments that are indeed never used inside
the function to suppress these kinds of compiler warnings.
Can you resubmit the patch after removing and reviewing these _U_ changes?
The problem here is that we are generating the code. In case we want to remove obsolete _U_s we would have to do generation in 2 passes (1st pass collects all the variables that will be actually used in the code, 2nd pass generates the code). Is the issue critical for you? 

Martin