Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Patch] pragma warning

["ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>]

I dont think it is really realistic to have all autogenerated files
always compile without any warnings.
Maybe we should instead split Makefile.common up into three parts :

First part : normal dissectors

Second part : ANS2WRS generated dissectors  which take extra compile
time flags and definitions to suppress artefacts from the compiler.

Third part : PIDL generated dissectors that once again take extra
compile parameters and definitions.




On 3/28/07, Graham Bloice <graham.bloice@xxxxxxxxxxxxx> wrote:
> Gisle Vanem wrote:
> > "Graham Bloice" <graham.bloice@xxxxxxxxxxxxx> wrote:
> >
> >> Gisle Vanem wrote:
> >>> The "#pragma warning()" statements are MSVC specific. So
> >>> embed them inside "#ifdef _MSC_VER".
> >>>
> >> I always thought unrecognised #pragma directives were ignored.  I take
> >> it that MinGw barfs on them in some way?
> >
> > MingW ignores them, but with a warning. I thought we should strive
> > to reduce the number of warnings. Hence my patch.
> >
>
> "Ignore" and "issues a warning" don't quite mesh in my dictionary, but
> now I understand what's up I support your solution.
>
> --
> Regards,
>
> Graham Bloice
>
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev