Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 21226: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Tue, 27 Mar 2007 09:05:23 -0700
On Tue, Mar 27, 2007 at 06:56:07PM +0800, Jeff Morriss wrote:

> Is there any reason ws_strsplit.h isn't included in some header file 
> all the dissectors already include (so each dissector that decides to 
> use g_strsplit() doesn't have to go include this new file)?
>
> Or, since the file is so short, just include the _contents_ of that 
> file somewhere?

I don't see any reason not to include ws_strsplit.h in a "globally 
included" file if there is one?  I think it should be kept as a separate 
include file though because that corresponds to ws_strsplit.c, which is 
about 4 pages long.


Steve