Wireshark · Wireshark-dev: [Wireshark-dev] FYI: Status of gcc warnings in epan/dissectors

[Stephen Fisher <stephentfisher@xxxxxxxxx>]

FYI: Update on warnings in epan/dissectors under gcc 4.0

Below is a list of the number of warnings remaining in epan/dissectors 
when using gcc 4.0.  There are 3,915 warnings in this directory across 
163 files.  Excluding files that show warnings as being in the .cnf 
filename (such as asn generated) files, there are "only" 795 warnings.  
This includes some pidl generated dissectors, whose warnings will be 
fixed by Ronnie once the Samba team commits his change to add _U_ to 
everything.

Almost all of the warnings I've fixed so far are "sign mismatches" 
between guint8* and (g)char* :(.  552 of the 795 remaining warnings 
outside of the .cnf files are this problem.

As Ulf said, the hole needs to be plugged to keep new warnings from 
creeping in.  Unfortunately, I don't think it is as straightforward to 
do with automake as it is under MSVC (adding a line to each file with 
warnings), especially with this many warnings remaining.  I can't add 
-Werror to epan/dissectors yet.  I do encourage everyone on Unix to 
compile with the configure option --with-warnings-as-errors to keep 
warnings from creeping into the directories where -Werror has been 
applied.

#Warn File
   1 ess.cnf
   1 h225.cnf
   1 h245.cnf
   1 logotype-cert-extn.cnf
   1 packet-MAP_DialoguePDU-fn.c
   1 packet-ansi_map-template.c
   1 packet-bacapp.c
   1 packet-cmip-fn.c
   1 packet-dap-fn.c
   1 packet-dccp.c
   1 packet-dcerpc-nt.c
   1 packet-dcerpc-rs_misc.c
   1 packet-dcerpc-spoolss.c
   1 packet-dcerpc-wkssvc.c
   1 packet-disp-fn.c
   1 packet-dsi.c
   1 packet-edonkey.c
   1 packet-frame.c
   1 packet-fw1.c
   1 packet-gsm_map-template.c
   1 packet-gssapi.c
   1 packet-hsrp.c
   1 packet-icep.c
   1 packet-igap.c
   1 packet-image-gif.c
   1 packet-ipdc.c
   1 packet-isup_thin.c
   1 packet-k12.c
   1 packet-m2ua.c
   1 packet-ospf.c
   1 packet-pana.c
   1 packet-pkix1implicit-fn.c
   1 packet-pkixtsp-fn.c
   1 packet-pktc.c
   1 packet-quake2.c
   1 packet-s5066.c
   1 packet-scsi.c
   1 packet-skinny.c
   1 packet-smb2.c
   1 packet-smrse-fn.c
   1 packet-sna.c
   1 packet-umts_rrc-fn.c
   1 packet-umts_rrc-template.c
   1 packet-ymsg.c
   1 pkcs12.cnf
   1 rrlp.cnf
   2 cms.cnf
   2 packet-acp133-fn.c
   2 packet-cmp-fn.c
   2 packet-dcerpc-efs.c
   2 packet-dcerpc-rpriv.c
   2 packet-dcerpc-rs_acct.c
   2 packet-dcerpc-rs_pgo.c
   2 packet-dhcp-failover.c
   2 packet-dhcpv6.c
   2 packet-ftp.c
   2 packet-gsm_ss-fn.c
   2 packet-gtp.c
   2 packet-megaco.c
   2 packet-nbns.c
   2 packet-ndps.c
   2 packet-pagp.c
   2 packet-pgm.c
   2 packet-pop.c
   2 packet-rmi.c
   2 packet-smb-browse.c
   2 packet-wsp.c
   3 cmip.cnf
   3 packet-dcerpc-afs4int.c
   3 packet-dcerpc-dfs.c
   3 packet-dcerpc-drsuapi.c
   3 packet-dcerpc-winreg.c
   3 packet-dcom.c
   3 packet-diameter.c
   3 packet-ess-fn.c
   3 packet-fcdns.c
   3 packet-fix.c
   3 packet-gnm-template.c
   3 packet-iax2.c
   3 packet-image-jfif.c
   3 packet-inap-template.c
   3 packet-iscsi.c
   3 packet-kerberos.c
   3 packet-q931.c
   3 packet-rtp.c
   3 packet-sdp.c
   3 packet-slowprotocols.c
   3 packet-umts_rrc_ies-template.c
   3 packet-umts_rrc_pdu_def-template.c
   3 packet-x509if-fn.c
   4 acse.cnf
   4 disp.cnf
   4 gsmmap.cnf
   4 h248.cnf
   4 packet-afp.c
   4 packet-ansi_map-template.c
   4 packet-cops.c
   4 packet-dcerpc-initshutdown.c
   4 packet-extreme.c
   4 packet-fcswils.c
   4 packet-h450-template.c
   4 packet-icap.c
   4 packet-kismet.c
   4 packet-quakeworld.c
   4 packet-smb-common.c
   4 packet-smtp.c
   4 tcap.cnf
   5 h235.cnf
   5 packet-dcerpc.c
   5 packet-distcc.c
   5 packet-ipp.c
   5 packet-mmse.c
   5 packet-ncp2222.inc
   5 packet-osi.c
   5 packet-rpc.c
   5 packet-umts_rrc_pdu_def-fn.c
   6 ansi_map.cnf
   6 ftam.cnf
   6 packet-dcerpc-eventlog.c
   6 packet-dcm.c
   6 packet-dop-fn.c
   6 packet-ldap-template.c
   6 packet-mount.c
   6 packet-msrp.c
   6 packet-rsync.c
   6 packet-slsk.c
   6 s4406.cnf
   7 packet-bittorrent.c
   7 packet-gnm-fn.c
   7 packet-isup.c
   7 packet-multipart.c
   7 x509if.cnf
   8 packet-dcerpc-srvsvc.c
   8 packet-gsm_sms.c
   8 packet-inap-fn.c
   9 ldap.cnf
   9 packet-mms-fn.c
  10 packet-nfs.c
  10 packet-smb-pipe.c
  11 packet-snmp-template.c
  12 camel.cnf
  12 packet-jxta.c
  13 packet-sip.c
  15 ansi_map.cnf
  15 packet-dcerpc-fldb.c
  16 packet-x509sat-fn.c
  18 packet-dcerpc-wzcsvc.c
  18 packet-pgsql.c
  18 packet-quake3.c
  20 packet-dns.c
  22 packet-srvloc.c
  26 packet-rtsp.c
  27 gnm.cnf
  36 packet-umts_rrc_ies-fn.c
  46 packet-h450-fn.c
  46 packet-http.c
  57 packet-giop.c
  58 inap.cnf
  58 packet-smb.c
  67 x411.cnf
 308 ranap.cnf
1228 rnsap.cnf
1335 nbap.cnf


Steve