Wireshark-dev: Re: [Wireshark-dev] [PATCH] USB: show unknown descriptors
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: "Charles Lepple" <clepple@xxxxxxxxx>
Date: Sun, 25 Mar 2007 22:03:50 -0400
On 3/25/07, ronnie sahlberg <ronniesahlberg@xxxxxxxxx> wrote:

I have a big patch to the dissector I am going to try to merge piece
by piece over the next few days.  This will result in many smallish
patches.

Since you are also working on patches to packet-usb.c  can I ask you
to send small patches and frequently so that none of us diverge too
much from eachother and svn?


OK.


The usb dissector is currently divided into two files
packet-usb.c and packet-usb-masstorage.c
My idea was to have packet-usb.c only contain the core part of the
protocol (and maybe also the HUB stuff)  while all other classes are
pushed out into its own specific file as far as possible.


Makes sense. Some of the type IDs still have to go into packet-usb.c,
of course, but I can start another file for packet-usb-hid.c.

--
- Charles Lepple