Wireshark · Wireshark-dev: Re: [Wireshark-dev] Patches for compilation warnings

[Ulf Lamping <ulf.lamping@xxxxxx>]

Peter Johansson wrote:
> Hi!
>  
> Ulf Lamping wanted help with getting rid of compiler warnings and I 
> agree. Its hard to see newly introduced warnings among all the other 
> ones. Hence here is a list of patches to address some of them on a 
> Windows build.
>  
> Note though that for packet-scsi, I also cleaned up intentation by 
> removing tabs inserting spaces to make the file a bit more consistent.
>  
> Regards, Peter
> ------------------------------------------------------------------------
Hi Peter!

Thanks for offering help in the quest for a warning free Wireshark.

Unfortunately, I've completely lost the track which warnings are already 
fixed and which still needs to be done.

I've already fixed e.g. the afp dissector. Be aware that at least some 
of the dcerpc dissectors are generated (as mentioned in the files 
comment header), so fixing the .c files won't help for long as the 
generation process must be fixed (I didn't had a deeper look at those 
files for now).

I'll try to fix the files in epan (without dissectors) and the plugins - 
as time permits.

Could you have a look at your patches and resend the ones that still 
needs to be applied?

Regards, ULFL