Wireshark-dev: Re: [Wireshark-dev] [PATCH] Plugins Warnings
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Sebastien Tandel <sebastien@xxxxxxxxx>
Date: Fri, 23 Mar 2007 19:35:40 +0100
Stephen Fisher wrote:
> On Fri, Mar 23, 2007 at 05:33:41PM +0100, Sebastien Tandel wrote:
>
>   
>> First patch fixes warning of profinet and megaco plugins to compile 
>> again with gcc-4.1.2.
>>     
>
> Committed as SVN revision 21155.  Thanks for your help!
>
>   
>> asn1 plugin is generating warnings. I'm correcting them now. I have 
>> nevertheless a question. offset in asn1_close and asn1_open is 
>> declared as int but never used as such in packet-asn1.c Could it be 
>> changed to guint in the structure _ASN1_SCK and in the aforementioned 
>> functions?
>>     
>
> Packet offsets in Wireshark are usually signed (negative meaning 
> starting at the end of the packet).  Can the unsigned uses of offset be 
> changed to match the _ASN1_SCK definition instead?
>   

Of course, it may be done that way. Offset was never used as signed in
packet-asn1 and it was just a much more quicker solution. I will sign it
then.



Regards,
Sebastien Tandel