Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH 2/2] asn1: New MPEG dissector

["ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>]

modified and checked in

On 3/16/07, Shaun Jackman <sjackman@xxxxxxxxx> wrote:
> On 8/25/06, Shaun Jackman <sjackman@xxxxxxxxx> wrote:
> > > 2, dont read straight into a bitfield struct.
> > > c does not define the packing order or padding of fields in a bitfield
> > > and this would be nonportable.
> > > please change to read into an array of char and then add code to
> > > manually unmarshall it into the fields of the bitfield
> >
> > Not yet done.
>
> Fixed now! The updated patch is attached. The decoder now dissects
> both MPEG audio and MPEG video! So, for example, it's possible to see
> the interleaving of MPEG video I, P, and B frames with MPEG audio.
>
> Cheers,
> Shaun
>
> 2006-08-25  Shaun Jackman  <sjackman@xxxxxxxxx>
>
>  * asn1/Makefile.am (EXTRA_DIST): Add mpeg.
>  * asn1/mpeg/Makefile: New file.
>  * asn1/mpeg/mpeg-audio.asn: Ditto.
>  * asn1/mpeg/mpeg-audio.cnf: Ditto.
>  * asn1/mpeg/mpeg-pes.asn: Ditto.
>  * asn1/mpeg/mpeg-pes.cnf: Ditto.
>  * asn1/mpeg/packet-mpeg-audio-template.c: Ditto.
>  * asn1/mpeg/packet-mpeg-pes-template.c: Ditto.
>  * epan/dissectors/Makefile.common (DISSECTOR_SRC):
>  Add packet-mpeg-audio.c and packet-mpeg-pes.c.