Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH 1/2] wiretap: New MPEG file format

["ronnie sahlberg" <ronniesahlberg@xxxxxxxxx>]

1, shouldnt the defines MPA_MARSHAL_... really be called
MPA_UNMARSHAL_... instead?


2, do you really need all these includes?
+#include <arpa/inet.h>
+#include <errno.h>
+#include <math.h>
+#include <stdint.h>
+#include <stdlib.h>
+#include <string.h>
+#include <time.h>
are all of these ones actually available on all platforms we support?


3, not all compilers we support allow you to declare variables mid-block
+		if (file_seek(wth->fh, 3, SEEK_CUR, err) == -1)
+			return FALSE;
+
+		uint8_t stream;

4, dont use these non-guintX types
uint8_t
use the g[u]int{8|16|32} from glib instead of these _t types.



On 3/17/07, Shaun Jackman <sjackman@xxxxxxxxx> wrote:
> On 3/15/07, Jeff Morriss <jeff.morriss@xxxxxxxxxxx> wrote:
> > Actually the patch isn't attached ;-)
>
> Grumble. =P
>
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev