Wireshark · Wireshark-dev: Re: [Wireshark-dev] h.223 robustness fixes

["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
Compile failes on Windows with:
packet-h223.c
packet-h223.c(596) : warning C4018: '<' : signed/unsigned mismatch
packet-h223.c(1156) : error C2065: 'uint' : undeclared identifier
packet-h223.c(1156) : error C2146: syntax error : missing ';' before
identifier
'needed'
packet-h223.c(1156) : error C2065: 'needed' : undeclared identifier
NMAKE : fatal error U1077: 'cl' : return code '0x2'
Stop.
Best regards
Anders

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Richard van der Hoff
Skickat: den 20 februari 2007 13:12
Till: Developer support list for Wireshark
Ämne: [Wireshark-dev] h.223 robustness fixes

Hi,

This patch improves the general robustness of the h.223 dissector 
(making it less likely to crash on malformed data).

Hopefully this also fixes a bug raised by Fabio Sguanci a few weeks ago. 
Fabio: I think a better way to fix the problem is to stop the dissector 
crashing when it finds a malformed PDU, so that it just treats the first 
pdu as malformed; there is then no need to special-case it.

I don't think this patch will apply cleanly without the "bitswapping" 
patch I submitted yesterday.

Thanks,

Richard