> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx
> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of
> Stephen Fisher
> Sent: 28 January 2007 02:54
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy
> packet data
>
> On Thu, Jan 11, 2007 at 01:59:56PM -0000, Douglas Pratley wrote:
>
> > This is a patch adding items to the context menus for the
> packet list
> > and packet details panes for copying packet data to the clipboard.
>
> I've checked in your changes as SVN revision 20581. Thanks
> for your contribution! I'll check in your documentation
> changes next. I did make the following changes:
Great! Glad to get something done.
>
> - Removed base64 encoding support as we discussed. This
> leaves room for a base64 decoder as a future feature.
>
Could you give an example of how you might see this working, perhaps
with a capture file?
Some initial thoughts - I think we'd need to give the user more power to
select an exact set of bytes (to avoid preamble / postamble). If we're
talking about e.g. mail attachments on SMTP, then the clipboard might
not be a good target - straight to file might be better. Are there any
other encodings / decodings it would be worth having available
(uuencode? zip?). This might be better done as a full "Select bytes and
decode / encode" feature rather than something in a copy menu.
In any case, probably best left until any changes coming out of
discussion of Ulf's email are carried out.
> - changed all calls to g_string_append_printf to
> g_string_sprintfa for
> GTK1 compatibility
>
> - changed call to g_ascii_isprint to isprint for GTK1 compatibility
> (proto_draw.c)
>
> - changed call to g_string_append_len to g_string_append for
> GTK1 compatability since it was appending the entire string anyway
> (proto_draw.c)
I've changed my bookmark in Firefox to point at the old GLib 1 API
documentation, so should avoid this in future.
>
>
> Thanks,
> Steve
>
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
Cheers
Doug
This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately.
Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies.
Detica Limited is registered in England under No: 1337451.
Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.
