Hi Steve
> -----Original Message-----
> From: wireshark-dev-bounces@xxxxxxxxxxxxx
> [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of
> Stephen Fisher
> Sent: 22 January 2007 01:10
> To: Developer support list for Wireshark
> Subject: Re: [Wireshark-dev] [PATCH] New menu items to copy
> packet data
>
> On Thu, Jan 11, 2007 at 01:59:56PM -0000, Douglas Pratley wrote:
>
> > This is a patch adding items to the context menus for the
> packet list
> > and packet details panes for copying packet data to the clipboard.
>
> Looking good so far. I fixed a few warnings about unused variables.
> BTW, if you have a function call that takes a parameter that
> it doesn't use you can put _U_ after it and Wireshark's
> compilation process will expand that to code that tells (gcc
> at least) not to warn about that.
>
Ah. I'm doing my development on Windows and not seeing these - I guess
MSCV6 doesn't warn on this at the level that Wireshark builds. While I'm
doing a build / test cycle on Fedora before sending out the patch, I've
not been checking the build output for warnings on gcc. I'll try to do
so in future.
> > I have not updated any documentation because I cannot find a
> > description of what context menu items do anywhere (main menu items
> > are listed in the man page). If I should have done, please let me
> > know.
>
> The documentation here needs to be updated with new screenshots and
> text:
> http://www.wireshark.org/docs/wsug_html_chunked/ChWorkDisplayP
> opUpSection.html
> You can find this chapter in the source as
> docbook/wsug_src/WSUG_chapter_work.xml.
>
OK - I'll get this done and send in a patch for the documentation. Are
you holding off on committing the code until I've done this?
>
> Steve
>
Cheers
Doug
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
This message should be regarded as confidential. If you have received this email in error please notify the sender and destroy it immediately.
Statements of intent shall only become binding when confirmed in hard copy by an authorised signatory. The contents of this email may relate to dealings with other companies within the Detica Group plc group of companies.
Detica Limited is registered in England under No: 1337451.
Registered offices: Surrey Research Park, Guildford, Surrey, GU2 7YP, England.
