Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH] Add support for the CIPSO IPv4 option

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

You at the right spot here, but sometimes it's a bit busy that review of
patches gets delayed. A headsup is always oke.

Few remarks on the patch.

Please attach the patch to your emails i.s.o. pasting them in. It makes
handling patches so much easier.

You've used some string handling glib functions which, to my knowledge,
aren't available in glib 1.2. Functions I've seen are g_stpcpy and
g_strlcat, but maybe there more. Can you verify this works on glib 1.2?

Thanx,
Jaap

On Fri, 19 Jan 2007, Paul Moore wrote:

> On Wednesday, January 17 2007 2:52 pm, Paul Moore wrote:
> > This patch adds support for the IPv4 Commercial IP Security Option (CIPSO)
> > as defined in the IETF draft, draft-ietf-cipso-ipsecurity-01.txt.  While
> > this draft has long since expired, it has become a de-facto standard for
> > labeled networking with support from several commercial Multi-Level
> > Security (MLS) operating systems such as HP-UX CMW and Trusted Solaris; in
> > addition, Linux Kernels 2.6.19 and later provide support for CIPSO in
> > conjunction with SELinux.
>
> I haven't heard any comments in regards to this patch and I was wondering if I
> used the wrong process to submit the patch.  Is there some other mailing list
> I should use?  Bugzilla?
>
> If I am simply being impatient please let me know and I promise to be quiet :)
>
> Thanks.
>
> --
> paul moore
> linux security @ hp
>