Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 20318: /trunk/epan/dissectors/ /trun
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Gerald Combs <gerald@xxxxxxxxxxxxx>
Date: Sun, 07 Jan 2007 22:28:46 -0800
Joerg Mayer wrote:
> On Thu, Jan 04, 2007 at 11:21:37PM +0000, gerald@xxxxxxxxxxxxx wrote:
>> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20318
>>
>> User: gerald
>> Date: 2007/01/04 11:21 PM
>>
>> Log:
>>  Don't lower-case our SSID and passphrase, otherwise we'll create an
>>  incorrect PSK hash.
> 
> The code still makes another mistake: The SSID is not a string - it's a
> binary object which may even contain 0x00 in the middle. The current
> airpcap code doesn't provide for that.

True.  The workarounds right now are to either omit the SSID (in which
case the passphrase will be matched against every SSID), or to use the
PSK hash directly, e.g. "wpa-pwd:MyPassword" or "wpa-psk:01020304...".
Is this sufficient, or should we add support for a hexadecimal form of
the SSID?