Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 20209: /trunk/epan/ftypes/ /trunk/epan/ftypes/: ftype-pc

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

It failed to build across the board, so I backed out the change, giving
ronnie the time to check in a working version.

Thanx,
Jaap

On Sun, 24 Dec 2006, Sebastien Tandel wrote:

> seems the same with pcre 5.0 on Debian
>
> ftype-pcre.c: In function 'pcre_tuple_new':
> ftype-pcre.c:52: warning: implicit declaration of function 'ep_malloc'
> ftype-pcre.c:52: warning: assignment makes pointer from integer without
> a cast
> ftype-pcre.c:63: error: invalid application of 'sizeof' to incomplete
> type 'pcre'
> ftype-pcre.c:64: error: invalid application of 'sizeof' to incomplete
> type 'pcre'
>
>
> pcre.h has declared pcre but not defined it, see the excerpt of pcre.h :
>
> ---
> struct real_pcre; /* declaration; the definition is private  */
> typedef struct real_pcre pcre;
> ---
> You can't then use sizeof() ...
>
> and ep_malloc does not exist ;)
>
> Sebastien Tandel
>
> Stephen Fisher wrote:
> > Revision 20209 introduced the following build errors on my FreeBSD Unix
> > machine.  I'm using pcre 6.7.
> >
> > ftype-pcre.c: In function `pcre_tuple_new':
> > ftype-pcre.c:52: warning: implicit declaration of function `ep_malloc'
> > ftype-pcre.c:52: warning: assignment makes pointer from integer without a cast
> > ftype-pcre.c:63: error: invalid application of `sizeof' to incomplete type `/usr/local/include/pcre.h'
> > ftype-pcre.c:64: error: invalid application of `sizeof' to incomplete type `/usr/local/include/pcre.h'
> > ftype-pcre.c:64: warning: statement with no effect
> >
> > On Sat, Dec 23, 2006 at 09:17:33PM +0000, sahlberg@xxxxxxxxxxxxx wrote:
> >
> >
> >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=20209
> >>
> >> User: sahlberg
> >> Date: 2006/12/23 09:17 PM
> >>
> >> Log:
> >>  make the PCRE ftype use ep allocated memory instead of g_malloced memory
> >>
> >> Directory: /trunk/epan/ftypes/
> >>   Changes    Path            Action
> >>   +20 -37    ftype-pcre.c    Modified
> >>
> > _______________________________________________
> > Wireshark-dev mailing list
> > Wireshark-dev@xxxxxxxxxxxxx
> > http://www.wireshark.org/mailman/listinfo/wireshark-dev
> >
>
>
> _______________________________________________
> Wireshark-dev mailing list
> Wireshark-dev@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-dev
>
>