Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH] New Dissector : Roofnet

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi,

Looks good. Some remarks though.
* I'm not sure about using get_hostname here. Shouldn't that be handled
through Wireshark services.
* The loop in dissect_roofnet should check that it doesn't spin out of
control when an incorrectly large value is read.
* Use %u i.s.o. %d when printing unsigned values
* Don't put a comma after the last entry in a structure array initializer
* Use the 'standard' file header as found in the README.developer

Thanx,
Jaap

On Tue, 19 Dec 2006, Sebastien Tandel wrote:

> Hi all,
>
>
>    Here is a patch (against svn rev 20149) for the dissector of the new
> Roofnet protocol.
>
>
>
> Regards,
> Sebastien Tandel
>