Wireshark-dev: Re: [Wireshark-dev] [PATCH] COS DSCP Column patch
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Stephen Fisher <stephentfisher@xxxxxxxxx>
Date: Sun, 10 Dec 2006 19:00:30 -0800
On Sun, Dec 10, 2006 at 04:00:39PM +0100, Thomas Sillaber wrote:

> here's the working patch/diff. Please test and apply!

Thanks.  Your patch looks fine and I will apply it soon.

While testing, I noticed that the way Wireshark sizes columns could use 
some tweaking (unrelated to your patch).  Since your new columns are 
narrow (one is one character and one is two), any column title longer 
than that doesn't make the column wider.  This causes the column titles 
to be unreadable and overlap into the columns next to it.  I'm going to 
see what I can do to fix that before I apply your patch.


Steve