Wireshark · Wireshark-dev: Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars

Wireshark-dev: Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars

From: Gerald Combs <gerald@xxxxxxxxxxxxx>

Date: Fri, 24 Nov 2006 22:22:01 -0800

Guy Harris wrote:
> Stefan (metze) Metzmacher wrote:
> 
>> if isprint() is used, we should make sure the value
>> isn't larger than 0xFF, as currently GDK_Up and GDK_Down
>> trigger a focus switch to the filter.
> 
> Should it be
> 
> 	if (isascii(event->keyval) && isprint(event->keyval))
> 
> so that control characters don't get intercepted, either?

Checked in.

References:
- [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
  - From: Stefan (metze) Metzmacher
- Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
  - From: Guy Harris

Prev by Date: Re: [Wireshark-dev] Why replace ntohl() with g_ntohl()?
Next by Date: Re: [Wireshark-dev] Wireshark crash on Windows (latest SVN)
Previous by thread: Re: [Wireshark-dev] [PATCH] gtk don't handle GDK_Up/GDK_Down as printable chars
Next by thread: [Wireshark-dev] [Wireshark Plugin] Accentued Characters
Index(es):
- Date
- Thread