Wireshark-dev: [Wireshark-dev] AppleTalk fix?
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Jaap Keuter <jaap.keuter@xxxxxxxxx>
Date: Thu, 16 Nov 2006 10:36:14 +0100 (CET)
Hi,

This is a patch for AppleTalk, at least to make one of my captures with
ZIP (GetNetInfo request) to work. Current dissector misses the Zone
UINT_STRING by one. At least I assume that it's the Zone string, could be
an additional string as well.

Index: packet-atalk.c
===================================================================
--- packet-atalk.c	(revision 19908)
+++ packet-atalk.c	(working copy)
@@ -1633,8 +1633,8 @@
       break;

   case 5 :  /* GetNetInfo request */
-      proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 1, FALSE);
-      offset++;
+      proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 2, FALSE);
+      offset += 2;
       proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 4, FALSE);
       offset += 4;
       proto_tree_add_item(zip_tree, hf_zip_zone_name, tvb, offset, 1,FALSE);

Anyone knowledgeable about AppleTalk wish to give their insight?

Thanx,
Jaap