Wireshark · Wireshark-dev: Re: [Wireshark-dev] 0.99.4 packaging fails on Windows

["Maynard, Chris" <Christopher.Maynard@xxxxxxxxx>]

On this topic of files missing from released versions:

First, I don't mean to criticize or to come across too harshly here.  We're all human; we all make mistakes.  However, the 0.99.3 tarball was missing at least one file, airpcap.h, and a 0.99.3a source tarball was later posted to remedy that issue.  Now it seems that the 0.99.4 tarball is missing a file or two.  I don't know if the best way to resolve it is to simply post a 0.99.4a source or to simply let developers search the mailing list and figure out what to do.  Whatever you decide is fine.

However, going forward, it seems to me that there should be a better way to test that the intended released sources (0.99.5, 0.99.6, ...) contain everything needed before the release is posted.  Perhaps many of you core developers have environments that don't exactly match what one would have if you simply untar-zip the source as provided, and therefore you may have files that the rest of us don't.  Maybe a slight change in release procedure would help?  Is it possible to build everything solely from the source tarball intended to be posted to ensure that it's self contained?

- Chris

-----Original Message-----
From: Maynard, Chris 
Sent: Friday, November 03, 2006 11:11 AM
To: 'Developer support list for Wireshark'
Subject: RE: [Wireshark-dev] 0.99.4 packaging fails on Windows

I built from the sources provided here: http://www.wireshark.org/download/src/wireshark-0.99.4.tar.gz, not from some arbitrary svn version.  The reason I do this is because I only release a custom installer to my company when a new version comes out from you guys; otherwise it would be far too time-consuming to build a new installer for every svn release.  In any case, that released version should have contained all the files required to build an installer on any platform.  So I'm not really sure what you're implying when you say that I should have built from an SVN checkout in the first place.  Moreover, I don't currently have a unix build environment to create the missing files, nor should you expect that everyone else building for the Windows platform will either.

That said, I have checked out the latest svn sources, currently at 19782, and I guess what you're saying is that in order to fix the problem regarding those missing files in the 0.99.4 release, simply copy those 2 missing files from the latest svn checkout to the 0.99.4 build directory, rather than updating the epan/wslua/Makefile.am file, which will not help anyone building on Windows.

- Chris


-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman (AL/EAB)
Sent: Friday, November 03, 2006 10:33 AM
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] 0.99.4 packaging fails on Windows

Hi,
The src package is built on unix. Updating the epan/wslua/Makefile.am will
Make the unix build include this files in the src package.

If you build from a a SVN checkout there isn't a problem in the first place.
/Anders  

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Maynard, Chris
Sent: den 3 november 2006 14:21
To: Developer support list for Wireshark
Subject: Re: [Wireshark-dev] 0.99.4 packaging fails on Windows

The link you sent for revision 19764 only lists one file that was changed, namely epan/wslua/Makefile.am.  This file is only used by automake, isn't it, which isn't used in a Windows build environment, so I don't think this will help.

-----Original Message-----
From: wireshark-dev-bounces@xxxxxxxxxxxxx [mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] On Behalf Of Anders Broman
Sent: Friday, November 03, 2006 2:42 AM
To: 'Developer support list for Wireshark'
Subject: Re: [Wireshark-dev] 0.99.4 packaging fails on Windows

Hi,
An attempt to fix it was checked in in rev 19764
http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19764
I have not had the time to test it though.
/Anders 

-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För Maynard, Chris
Skickat: den 3 november 2006 01:11
Till: Developer support list for Wireshark
Ämne: [Wireshark-dev] 0.99.4 packaging fails on Windows

I successfully compiled Wireshark 0.99.4 on a Win32 platform, but when I ran "nmake -f Makefile.nmake packaging", it failed as follows:

========================================
......
File: "libtasn1-3.dll" 538493 bytes
File: "lua5.1.dll" 114688 bytes
File: "init.lua" 5611 bytes
File: "..\..\epan\wslua\console.lua" -> no files found.
Usage: File [/nonfatal] [/a] ([/r] [/x filespec [...]] filespec [...] |
   /oname=outfile one_file_only)
Error in script "wireshark.nsi" on line 335 -- aborting creation process NMAKE : fatal error U1077: '"C:/program files/nsis/makensis.exe"' :
return code
'0x1'
Stop.
NMAKE : fatal error U1077: '"C:\Program Files\Microsoft Visual Studio\VC98\Bin\ MAKE.EXE"' : return code '0x2'
Stop.

C:\wireshark-0.99.4>
========================================

It seems that the wireshark.nsi file includes these 2 lines [335-336], but neither file is present in the epan\wslua\ directory:

File "..\..\epan\wslua\console.lua"
File "..\..\epan\wslua\dtd_gen.lua"

Did "nmake -f Makefile.nmake" truly succeed and these 2 lines should simply be removed from the wireshark.nsi file, or should these 2 files actually be there and something went wrong during compilation, or something else?  I commented out the 2 lines and the installer seemed to build and install OK, but I guess I just wanted to make sure nothing is missing, such as the ..\epan\wslua\template-init.lua file, for example.

Thanks in advance,
Chris Maynard


-----------------------------------------
This email may contain confidential and privileged material for the
sole use of the intended recipient(s). Any review, use, retention,
distribution or disclosure by others is strictly prohibited. If you
are not the intended recipient (or authorized to receive for the
recipient), please contact the sender by reply email and delete all
copies of this message. Also, email is susceptible to data
corruption, interception, tampering, unauthorized amendment and
viruses. We only send and receive emails on the basis that we are
not liable for any such corruption, interception, tampering,
amendment or viruses or any consequence thereof.