Wireshark · Wireshark-dev: Re: [Wireshark-dev] [Wireshark-commits] rev 19684: /trunk//trunk/epan/dissectors/: packet-h248.c pac

["Anders Broman" <a.broman@xxxxxxxxx>]

Hi,
The changes in V3 are minor and I tried to put back everything
Else done in the asn1 file but commenting it this time, so I think the big
risk for bugs are in the code added for packages.
But no guaranties...

BR
Anders
-----Ursprungligt meddelande-----
Från: wireshark-dev-bounces@xxxxxxxxxxxxx
[mailto:wireshark-dev-bounces@xxxxxxxxxxxxx] För LEGO
Skickat: den 25 oktober 2006 19:21
Till: wireshark-dev@xxxxxxxxxxxxx
Ämne: Re: [Wireshark-dev] [Wireshark-commits] rev 19684:
/trunk//trunk/epan/dissectors/: packet-h248.c
packet-h248.h/trunk/asn1/h248/: packet-h248-template.c

You beat me by few seconds (not kidding)...

There's an issue here:
The h248v3 asn hasn't yet been tested...

I believe it would be better to revert the changes to the generated
dissector and make them by hand.

Then let the v3 asn for the next release.

Anders, what do you think?

On 10/25/06, gerald@xxxxxxxxxxxxx <gerald@xxxxxxxxxxxxx> wrote:
> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19684
>
> User: gerald
> Date: 2006/10/25 05:00 PM
>
> Log:
>  Add more paranoid pointer checks.  Fixes CID 219.
>
> Directory: /trunk/epan/dissectors/
>   Changes    Path             Action
>   +477 -1048 packet-h248.c    Modified
>   +2 -2      packet-h248.h    Modified
>
> Directory: /trunk/asn1/h248/
>   Changes    Path                      Action
>   +64 -64    packet-h248-template.c    Modified
>
> _______________________________________________
> Wireshark-commits mailing list
> Wireshark-commits@xxxxxxxxxxxxx
> http://www.wireshark.org/mailman/listinfo/wireshark-commits
>


-- 
This information is top security. When you have read it, destroy yourself.
-- Marshall McLuhan
_______________________________________________
Wireshark-dev mailing list
Wireshark-dev@xxxxxxxxxxxxx
http://www.wireshark.org/mailman/listinfo/wireshark-dev