Wireshark-dev: Re: [Wireshark-dev] Wireshark 0.99.4pre1 is now available
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Ulf Lamping <ulf.lamping@xxxxxx>
Date: Sun, 22 Oct 2006 16:02:30 +0200
Tobias Erichsen wrote:

Hi again,

no problem.  I have already started to move a good amount of the
literals into the h-file and I will try to move all I can into
"value_string" arrays.

But this won't be possible for everything, as MIDI itself has
some "specialities" already within the coding and RTP-MIDI takes
this even one step further...

So I won't get around the use of a couple of "add_text()" calls.

Apart from that, I noticed quite a few other plugins to use the
"add_text()" pretty regularly - so what's the reason not to use it?

Didn't have looked into the details, so only general thoughts.

I guess you and Jaap are talking about proto_tree_add_text().
Well, add_text is providing the least possible information to the dissection engine.
For example: if you have an integer and use add_text to show it to the tree you cannot effectively filter on it, you cannot write a coloring rule for it, ...
It's about providing meta information, which can then be used by others (and yourself) to do more advanced things. 

Regards, ULFL