Wireshark · Wireshark-dev: Re: [Wireshark-dev] Patch: Improvements for TIPC dissector package-tipc.c

[Jaap Keuter <jaap.keuter@xxxxxxxxx>]

Hi Martin,

Some remarks:
1. The attachement was a actually a tar.gz
2. It's a BIG patch
3. It doesn't apply cleanly to the HEAD

so, if you could:
1. send a 2 patch set, with
a. protocol changes relative to HEAD first, for easier review
b. cleanup changes to patched HEAD second.
2. also cleanup the end of the initializers, the last element shall not
have a trailing comma.

Thanx,
Jaap

On Thu, 28 Sep 2006, Martin Peylo wrote:

> Hi,
>
> The attached patch (against wireshark 0.99.3a) mainly
> improves following aspects of the TIPC dissector:
>
> - dissection of TIPCv2 internal messages now shows
>   all fields used according to the protocol spec
> - there should be no issues with the current protocol
>   spec anymore
> - the info column is more concise and gives more
>   details
> - some code beautifications
>
> Could someone please review it and - if ok - commit it?
>
> If there are any issues left or raised please CC a mail to:
> martin <dot> peylo <at> siemens <dot> com
>
> Thanks,
> Martin Peylo
>