Wireshark-dev: Re: [Wireshark-dev] Defending against NULL dissector handles
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Joerg Mayer <jmayer@xxxxxxxxx>
Date: Thu, 10 Aug 2006 12:09:47 +0200
On Wed, Aug 09, 2006 at 06:25:59PM +0100, Neil Piercy wrote:
> Should call_dissector include explicit null handle checks, and if so, 
> should it:-
> 
> a) g_assert - the simple patch attached
> b) fallback to doing a data decode (as disabled protocols do)
> c) try to invoke the wireshark exception handling for the packet

IMO, a) is valid behaviour and while b) might be interesting I haven't
thought through all the consequences in other places that could happen
if we made null handles a feature.

Committed revision 18869.

Thanks!
  Joerg

-- 
Joerg Mayer                                           <jmayer@xxxxxxxxx>
We are stuck with technology when what we really want is just stuff that
works. Some say that should read Microsoft instead of technology.