Wireshark-commits: [Wireshark-commits] master 79e43ef: EAP: Update to EAP Identity Dissection
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 10 Aug 2020 04:54:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=79e43ef98d59ecfdab5667a6a55b078dab825fdd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

79e43ef by Matthew Weant (msweant@xxxxxxxxx):

    EAP: Update to EAP Identity Dissection
    
    Removed WLAN from the EAP identity fields because
    it is additional and unnecessary.  Added fields for
    the full identity string and the identity type.
    Removed the pseudo and reauth identity types by
    collapsing all identity values into one field
    (eap.identity) so the values may be filtered easier
    by users in tshark and the GUI.  Omitting
    encrypted IMSI code until this patch and Change
    37250 get merged since the encrypted IMSI logic
    depends on these two patches.
    
    Bug: 16537
    Change-Id: If359756c1949aff2510b822b70e0e79df85213d0
    Reviewed-on: https://code.wireshark.org/review/37257
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bb5d031   Fix merge cruft from release-notes.adoc
     add  79e43ef   EAP: Update to EAP Identity Dissection


Summary of changes:
 epan/dissectors/packet-eap.c | 131 +++++++++++++++++++++++++------------------
 1 file changed, 77 insertions(+), 54 deletions(-)