Wireshark-commits: [Wireshark-commits] master 898b00c: Qt: Restore an attribution.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 30 Jul 2020 05:31:20 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=898b00c9a12150dfac5e5f6dd93b742cbb14aec7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

898b00c by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Qt: Restore an attribution.
    
    The ByteViewText widget has been refactored a few times. At one point it
    was based on QHexView by Evan Teran, and had a comment saying so. A
    later refactor removed the comment but didn't completely rewrite all of
    the code. Put the comment back (and spell Evan's name correctly this
    time around).
    
    Change-Id: I2fe7779e1b6773a5e8b38d317ebfd26b07900272
    Reviewed-on: https://code.wireshark.org/review/37989
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  28bec58   CDP: Improve CDP port ID TLV hack heuristic
     add  898b00c   Qt: Restore an attribution.


Summary of changes:
 ui/qt/widgets/byte_view_text.cpp | 3 +++
 1 file changed, 3 insertions(+)