Wireshark-commits: [Wireshark-commits] master 6432e18: FTDI FT: Do not add Reassembled data source
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 18 Jul 2020 04:01:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6432e18b2a4ea0793dfbc8cf057bcc7dbf028ea8
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

6432e18 by Tomasz Moń (desowin@xxxxxxxxx):

    FTDI FT: Do not add Reassembled data source on first pass
    
    This results in tshark not printing "Reassembled" during the first pass.
    Not printing "Reassembled" data source prevents use-after-free. Also,
    "Reassembled" data source on first pass does not necessarily represent
    complete reassembly as it is possible that data from subsequent packets
    will be appended.
    
    Bug: 16698
    Change-Id: I8fa807c400dd6b269a2f491d7ea8d86f875ef873
    Reviewed-on: https://code.wireshark.org/review/37868
    Petri-Dish: Tomasz Moń <desowin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  19e583a   Stun: improve ipv6 addresses visualization
     add  6432e18   FTDI FT: Do not add Reassembled data source on first pass


Summary of changes:
 epan/dissectors/packet-ftdi-ft.c | 1 -
 1 file changed, 1 deletion(-)