Wireshark-commits: [Wireshark-commits] master 9e36715: SMB: fix Response of SMB_COM_LOCKING_ANDX (0
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Jun 2020 06:27:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9e3671562c23925f57c699ac303437713a3b4fef
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

9e36715 by Zhenhua Hu (fattiger1102@xxxxxxxxx):

    SMB: fix Response of SMB_COM_LOCKING_ANDX (0x24)
    
    Pass Length=0 to proto_tree_add_item will cause get_uint_value
    to throw error of 'Trying to fetch an unsigned integer with length 0'.
    
    Change-Id: I0fb457d175b719517419291adaedef5cacc9544a
    Reviewed-on: https://code.wireshark.org/review/37614
    Reviewed-by: Zhenhua Hu <fattiger1102@xxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  360ae8b   couchbase: Fix dissect length of status!=0 values
     add  9e36715   SMB: fix Response of SMB_COM_LOCKING_ANDX (0x24)


Summary of changes:
 epan/dissectors/packet-smb.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)