Wireshark-commits: [Wireshark-commits] master 360ae8b: couchbase: Fix dissect length of status!=0 v
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 30 Jun 2020 04:21:45 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=360ae8b1c0ce73580e497437c077af5b6ec846f6
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

360ae8b by Dave Rigby (daver@xxxxxxxxxxxxx):

    couchbase: Fix dissect length of status!=0 values
    
    When dissecting response values with a non-zero status, the length
    calculation was incorrectly using the entire bodylen and not the
    actual value_len. This is likely due to an error in adding support for
    flex_frame_extras, before which bodylen == valuelen.
    
    Change-Id: I1d622bea582abcfafc5e97881d94fd7a7db6c80a
    Reviewed-on: https://code.wireshark.org/review/37598
    Reviewed-by: Ben Huddleston <ben.huddleston@xxxxxxxxxxxxx>
    Reviewed-by: Jim Walker <jim@xxxxxxxxxxxxx>
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  07ece89   RTPS: don't add an unitialized info structure to a table.
     add  360ae8b   couchbase: Fix dissect length of status!=0 values


Summary of changes:
 epan/dissectors/packet-couchbase.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)