Wireshark-commits: [Wireshark-commits] master d933a98: A-bis/RSL: fix wrong parent tree in dissect_
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 27 Jun 2020 19:29:36 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d933a98f893b59a51fba9986a75024f3fc3c1537
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d933a98 by Vadim Yanitskiy (vyanitskiy@xxxxxxxxxxx):

    A-bis/RSL: fix wrong parent tree in dissect_rsl_ie_cause()
    
    Cause specific fields belong to the 'Cause IE', so they should be
    correctly displayed in the tree hierarchy.
    
    Before this change:
    
        0111 111. = Message discriminator: ip.access Vendor Specific messages (63)
        .... ...0 = T bit: Not considered transparent by BTS
        .111 0110 = Message type: ip.access DLCX INDication (0x76)
        Channel number IE
            Element identifier: Channel Number (0x01)
            0000 1... = C-bits: Bm + ACCH (1)
            .... .010 = Time slot number (TN): 2
        Cause IE
            Element identifier: Cause (0x1a)
            Length: 1
        0... .... = Extension: No Extension
        .000 .... = Class: Normal event (0)
        .000 1111 = Cause Value: normal event, unspecified (15)
    
    After:
    
        0111 111. = Message discriminator: ip.access Vendor Specific messages (63)
        .... ...0 = T bit: Not considered transparent by BTS
        .111 0110 = Message type: ip.access DLCX INDication (0x76)
        Channel number IE
            Element identifier: Channel Number (0x01)
            0000 1... = C-bits: Bm + ACCH (1)
            .... .010 = Time slot number (TN): 2
        Cause IE
            Element identifier: Cause (0x1a)
            Length: 1
            0... .... = Extension: No Extension
            .000 .... = Class: Normal event (0)
            .000 1111 = Cause Value: normal event, unspecified (15)
    
    Change-Id: I9dc3a35dff19fc824b69f66ef137f0346247af3a
    Signed-off-by: Vadim Yanitskiy <vyanitskiy@xxxxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37565
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2dcf32b   coap: Mark private and vendor-specific options as unknown
     add  d933a98   A-bis/RSL: fix wrong parent tree in dissect_rsl_ie_cause()


Summary of changes:
 epan/dissectors/packet-rsl.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)