Wireshark-commits: [Wireshark-commits] master dc023ad: CMake: warn for older Libgcrypt version
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 24 Jun 2020 04:17:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=dc023ad68a18744183f56564562e81ab2da53cdd
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

dc023ad by Peter Wu (peter@xxxxxxxxxxxxx):

    CMake: warn for older Libgcrypt version
    
    Libgcrypt enables decryption for so many protocols, be sure to warn
    users when their Wireshark build is constrained due to an old version.
    Previously a user on Ubuntu 16.04 was surprised that QUIC decryption did
    not work even though the "minimum required" version was satisfied:
    
        Found GCRYPT: /usr/lib/x86_64-linux-gnu/libgcrypt.so (found suitable
        version "1.6.4", minimum required is "1.4.2")
    
    Change-Id: Ief927b8892a6be9f994bdc65619a1236ca2f4fa7
    Reviewed-on: https://code.wireshark.org/review/37552
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4b2cecc   TCP: show relative numbers only when tcp_analyze_seq is enabled
     add  dc023ad   CMake: warn for older Libgcrypt version


Summary of changes:
 CMakeLists.txt | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)