Wireshark-commits: [Wireshark-commits] master 933067a: ACDR: don't call the JSON dissector as an AC
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 15 Jun 2020 22:04:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=933067acc2a0304e0c85d395e35e10a206a6ef9b
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

933067a by Guy Harris (gharris@xxxxxxxxx):

    ACDR: don't call the JSON dissector as an ACDR media type dissector.
    
    We pass an acdr_dissector_data_t * to dissectors for the
    "acdr.media_type" dissector table, but the JSON dissector expects an
    http_message_info_t *.
    
    Hilarity ensues.
    
    Instead, have our own dissector for VoiceAI, that calls the JSON
    dissector and passes it *no* data.
    
    Bug: 16622
    Change-Id: Icb5b216ed63ab02680372836885b27de9541684c
    Reviewed-on: https://code.wireshark.org/review/37484
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  526a9a6   New dissector: Asphodel Protocol
     add  933067a   ACDR: don't call the JSON dissector as an ACDR media type dissector.


Summary of changes:
 epan/dissectors/packet-acdr.c | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)