Wireshark-commits: [Wireshark-commits] master 326a436: version_info: fix clang output.
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 15 Jun 2020 11:56:07 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=326a43627a70d11371b3f99f3f59f44665065397
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

326a436 by Dario Lombardo (lomato@xxxxxxxxx):

    version_info: fix clang output.
    
    Clang's __VERSION__ shows a trailing space. This ends up in a useless
    space before the period, that shows a different output from other
    compilers. Example:
    
    Built using clang Clang 10.0.0 .
    Built using gcc 7.5.0.
    
    Fixed by stripping it in clang only.
    
    Change-Id: I98dfce46b189fc6b2b58950dbb27f69d271bd729
    Reviewed-on: https://code.wireshark.org/review/37480
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  ef8da8e   acdr: remove unused variables.
     add  326a436   version_info: fix clang output.


Summary of changes:
 version_info.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)