Wireshark-commits: [Wireshark-commits] master 499a49f: dot11decrypt: Remove DEBUG_TRACE_START/END m
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 May 2020 10:33:49 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=499a49fd844b133e5feaf195dbfe8b538d061d97
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

499a49f by Mikael Kanstrup (mikael.kanstrup@xxxxxxxx):

    dot11decrypt: Remove DEBUG_TRACE_START/END macros
    
    The function tracing functions DEBUG_TRACE_START/END are only
    used in a few functions and START/END often don't match making
    them unreliable. Remove these macros and their usage as it
    clutters code without adding any useful debug capabilities.
    
    Change-Id: I7ea214c07ba1f35cc546942b5d4737f5752d20a7
    Reviewed-on: https://code.wireshark.org/review/37306
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  685a125   dot11decrypt: Remove some unused code
     add  499a49f   dot11decrypt: Remove DEBUG_TRACE_START/END macros


Summary of changes:
 epan/crypt/dot11decrypt.c       | 29 -----------------------------
 epan/crypt/dot11decrypt_debug.h | 10 ----------
 2 files changed, 39 deletions(-)