Wireshark-commits: [Wireshark-commits] master 4d801ab: packer-kerberos: maintain enc_key_t->id as a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 25 May 2020 05:03:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4d801abad0707263621d7c4c426b68d2061e0c75
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

4d801ab by Stefan Metzmacher (metze@xxxxxxxxx):

    packer-kerberos: maintain enc_key_t->id as a unique number
    
    The id is relative to the frame number, -1 means "keytab".
    
    A key with a lower value means it was learned before
    a key with a higher value.
    
    This will make it easier to match keys, between learning and using.
    
    Change-Id: I7b44626b4724dbd541c4702e3b9aa9350d809b08
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37279
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  bc26b5e   packet-kerberos: pass more information down to add_encryption_key()
     add  4d801ab   packer-kerberos: maintain enc_key_t->id as a unique number


Summary of changes:
 .../asn1/kerberos/packet-kerberos-template.c       | 24 ++++++++++-----
 .../asn1/kerberos/packet-kerberos-template.h       |  8 +++++
 epan/dissectors/packet-kerberos.c                  | 36 ++++++++++++++--------
 epan/dissectors/packet-kerberos.h                  | 10 +++++-
 4 files changed, 57 insertions(+), 21 deletions(-)