Wireshark-commits: [Wireshark-commits] master a9b0db1: PFCP: fix Trace Information IE
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 16 May 2020 14:17:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a9b0db19c03a923705aa5ff17e9aaaa7139e0108
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

a9b0db1 by Yoshiyuki Kurauchi (ahochauwaaaaa@xxxxxxxxx):

    PFCP: fix Trace Information IE
    
    This commit fixes wrong dissection on the following fields
    in Trace Information IE.
    
    Session Trace Depth: don't overwrite length_trigger_events.
    List of Interfaces: use length_list_interfaces instead of
      length_list_trigger_events.
    IP Address of Trace Collection Entity:
      * dissect as IPv4 or IPv6 depending on the length.
      * rename the field with the full name defined in spec.
    
    Change-Id: I53537bfd61149fe42417667799c0542b98815882
    Signed-off-by: Yoshiyuki Kurauchi <ahochauwaaaaa@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/37212
    Reviewed-by: Joakim Karlsson <oakimk@xxxxxxxxx>
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  cf340fa   USB: fix redundant assignments or tests flagged by PVS-Studio
     add  a9b0db1   PFCP: fix Trace Information IE


Summary of changes:
 epan/dissectors/packet-pfcp.c | 26 ++++++++++++++++++--------
 1 file changed, 18 insertions(+), 8 deletions(-)