Wireshark · Wireshark-commits: [Wireshark-commits] master 90d1a9d: scylla: fix tree sizes and offsets

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=90d1a9de4392992544c44923d7ba0247a582aacb
Submitter: "Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

90d1a9d by Piotr Sarna (sarna@xxxxxxxxxxxx):

    scylla: fix tree sizes and offsets
    
    The following sizes and offsets were incorrect:
     - negotiation frame size (negotiation header size was used)
     - response frame size (response frame header size was used)
     - request frame size (response(sic!) frame header size was used)
     - mutation subtree offset (resulting in wrong subtree size too)
     - partition key subtree offset (resulting in wrong subtree size too)
    
    Also, negotiation/response frames were not dissected correctly if they were
    shorter than request header size (28) - they are correctly handled now.
    Additionally, Seastar RPC magic sequence (SSTARRPC) is explicitly
    added to the negotiation tree in order to explicitly show each part
    of the frame.
    
    Change-Id: Ibc5024b329113e98a363cfeb40223d61b9473fb2
    Reviewed-on: https://code.wireshark.org/review/37186
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  da8c28d   CIP Motion: Connection Configuration Data
     add  90d1a9d   scylla: fix tree sizes and offsets


Summary of changes:
 epan/dissectors/packet-scylla.c | 59 +++++++++++++++++++++++++----------------
 1 file changed, 36 insertions(+), 23 deletions(-)