Wireshark-commits: [Wireshark-commits] master-3.2 f6e8731: RTSP/SDP: Fix parsing error for H264:spr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 11 May 2020 08:28:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f6e8731eb0aea079b765dd660286bc575a70a1c0
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

f6e8731 by Sergey Bogdanov (Sergey.Bogdanov@xxxxxxxxxxxx):

    RTSP/SDP: Fix parsing error for H264:sprop-parameter-sets
    
    Rework the method verifying  if there are more data in packed attribute
    New version checks if there are any non-zero bits after the current bit in the
    packet. If it sees some non-zero bits - that means there is some data in the
    packet. If there are zero bits only - that means there is no more data in the
    packet.
    Changes affect RTSP/SDP dissector and they are specific for
    SDP media attribute (a) fmtp/sprop-parameter-sets for H264 protocol
    
    Bug: 16322
    Change-Id: Ic4768c56f16b79cbf2ccac8a9736f8fa15043224
    Reviewed-on: https://code.wireshark.org/review/36899
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 5f80801adda1b59f714373cfc636893d7aea41f1)
    Reviewed-on: https://code.wireshark.org/review/36989
    

Actions performed:

    from  303aa26   [Automatic update for 2020-05-10]
     add  f6e8731   RTSP/SDP: Fix parsing error for H264:sprop-parameter-sets


Summary of changes:
 epan/dissectors/packet-h264.c | 50 +++++++++++++++++++++++++------------------
 1 file changed, 29 insertions(+), 21 deletions(-)