Wireshark-commits: [Wireshark-commits] master-3.2 64f9812: SOMEIP: Bugfix for SOME/IP-SD Collision
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 05 May 2020 18:19:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=64f981271c4187e2ee06852cf78231a9a3353b33
Submitter: "Gerald Combs <gerald@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

64f9812 by Dr. Lars Völker (lars.voelker@xxxxxxxxxxxxxxxxxxxxxxx):

    SOMEIP: Bugfix for SOME/IP-SD Collision of Unique ID
    
    The unique id for SOME/IP-SD was not unique for eventgroups since
    it was made up by the service id and instance id only.
    This patch adds the eventgroup id to fix this.
    
    Bug: 16549
    Change-Id: I16bf0884d4a7bc1d3df5de868833fb1887ba0baa
    Reviewed-on: https://code.wireshark.org/review/37131
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 6ada4302b545d28a2bf2b8711382051f50363b6d)
    Reviewed-on: https://code.wireshark.org/review/37149
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  9ccd6b0   Infiniband: skip past the undissected vendor header.
     add  64f9812   SOMEIP: Bugfix for SOME/IP-SD Collision of Unique ID


Summary of changes:
 epan/dissectors/packet-someip-sd.c | 34 +++++++++++++++++-----------------
 1 file changed, 17 insertions(+), 17 deletions(-)