Wireshark-commits: [Wireshark-commits] master-3.2 099a7ea: pcapng: expert info when packet or ISB a
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 04 May 2020 18:58:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=099a7ea5b3a73a6e595fabd54daf39256763a654
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

099a7ea by David Perry (boolean263@xxxxxxxxxxxxxx):

    pcapng: expert info when packet or ISB appear without interfaces
    
    A valid pcapng file must have an IDB before any EPB/SPB/PB/ISB. So check
    our interface count when we parse the first such block of a section, and
    add expert info if there are no interfaces.
    
    Discovered during work on Bug #16526.
    
    Ping-Bug: 16526
    Change-Id: I23ff452fd163a0e4472e0658a905f85ab85d5e9d
    Reviewed-on: https://code.wireshark.org/review/36986
    Reviewed-by: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Petri-Dish: Jaap Keuter <jaap.keuter@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 1a9c5364d18b32c5fef72c0bcb3ea2095e60d8b0)
    Reviewed-on: https://code.wireshark.org/review/37100
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  63928ce   Generate a dummy description if we don't have an interface name.
     add  099a7ea   pcapng: expert info when packet or ISB appear without interfaces


Summary of changes:
 epan/dissectors/file-pcapng.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)