Wireshark-commits: [Wireshark-commits] master-3.0 bfbbc35: Fix some issues seen with a fresh run of
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 03 May 2020 07:24:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bfbbc3571fd125295eae3fad9e6d7cfe51bf27b9
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master-3.0
Repository: wireshark

Commits:

bfbbc35 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    Fix some issues seen with a fresh run of PVS Studio
    
    /opt/SourceCode/wireshark/epan/dissectors/packet-aoe.c	328	warn	V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 323, 328.
    /opt/SourceCode/wireshark/epan/dissectors/packet-aprs.c	1148	warn	V1037 Two or more case-branches perform the same actions. Check lines: 1148, 1161
    /opt/SourceCode/wireshark/epan/dissectors/packet-rpc.c	3385	warn	V547 Expression 'conversation == NULL' is always true.
    /opt/SourceCode/wireshark/epan/dissectors/packet-snort-config.c	465	note	V576 Incorrect format. Consider checking the fourth actual argument of the 'g_snprintf' function. Under certain conditions the pointer can be null.
    /opt/SourceCode/wireshark/epan/dissectors/packet-snort.c	630	warn	V768 The variable 'condition' is of enum type. It is odd that it is used as a variable of a Boolean-type.
    /opt/SourceCode/wireshark/epan/dissectors/packet-snort.c	969	warn	V547 Expression '!attempt_match' is always false.
    
    Bug: 16335
    Change-Id: I93bbc40f0467ebaab74335f6edc7d60e1c600a94
    Reviewed-on: https://code.wireshark.org/review/37044
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    (backported from commit b99dcf0593e105bf46603e714d295b04b72c28bd)
    Reviewed-on: https://code.wireshark.org/review/37060
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  d3ea06c   stats_tree: plug a memory leak.
     add  bfbbc35   Fix some issues seen with a fresh run of PVS Studio


Summary of changes:
 epan/dissectors/packet-aoe.c   |  4 +---
 epan/dissectors/packet-aprs.c  |  2 +-
 epan/dissectors/packet-rpc.c   |  3 +--
 epan/dissectors/packet-snort.c | 14 +++-----------
 epan/dissectors/snort-config.c | 11 +++++++++--
 5 files changed, 15 insertions(+), 19 deletions(-)