Wireshark · Wireshark-commits: [Wireshark-commits] master be63a17: wiretap: move the "fake an IDB for pcap files" code to libpcap.c

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=be63a17e542fe7f2df548db1816feaaec66417ea
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

be63a17 by Guy Harris (guy@xxxxxxxxxxxx):

    wiretap: move the "fake an IDB for pcap files" code to libpcap.c.
    
    That can just be done at the end of libpcap_open(), rather than in
    wtap_open_offline() immediately after the open routine - which, in this
    case, would be libpcap_open() - returns.  That's cleaner, as it puts
    capture-file-type-dependent code in the capture-file-type-specific code.
    
    Note, though, that it's a bit weird for LINKTYPE_ERF files (and it was
    equally weird before this change), and that other capture file types
    should be doing this as well.
    
    Change-Id: Ida94779a2e1021c81314f82655ec1d0f2f14e960
    Reviewed-on: https://code.wireshark.org/review/37022
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  7d95c27   ERF: split wiretap/erf.h into three files.
     add  be63a17   wiretap: move the "fake an IDB for pcap files" code to libpcap.c.


Summary of changes:
 wiretap/file_access.c | 23 -----------------------
 wiretap/libpcap.c     | 41 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 23 deletions(-)