Wireshark · Wireshark-commits: [Wireshark-commits] master 582ad24: Remove some single-SHB assumptions.

[Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>]

URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=582ad24c38713722695177fabafbd3d47ecb1d7d
Submitter: "Guy Harris <gharris@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

582ad24 by Guy Harris (guy@xxxxxxxxxxxx):

    Remove some single-SHB assumptions.
    
    Make wtap_file_get_shb() take a section number argument, and update code
    that called it.  In most cases, we convert the code to iterate over
    sections; in cases where a big code change would be required, we
    temporarily pass it 0 and mark the code as "needs to be updated for
    multiple sections".
    
    Eliminate cf_read_section_comment(); in calls outside file.c, other code
    directly calls the libwiretap routines it calls and, inside file.c, we
    just transplant the code and then fix it not to assume a single SHB.
    
    Change-Id: I85e94d0a4fc878e9d937088759be04cb004e019b
    Reviewed-on: https://code.wireshark.org/review/37000
    Petri-Dish: Guy Harris <gharris@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <gharris@xxxxxxxxx>
    

Actions performed:

    from  3a32757   CMake: Fix FindGLIB2 for saner output
     add  582ad24   Remove some single-SHB assumptions.


Summary of changes:
 capinfos.c                               | 133 ++++++++++--------
 debian/libwiretap0.symbols               |   1 +
 file.c                                   |  47 ++++---
 file.h                                   |   9 --
 ui/qt/capture_file_properties_dialog.cpp | 222 +++++++++++++++++--------------
 wiretap/wtap.c                           |  12 +-
 wiretap/wtap.h                           |  20 ++-
 7 files changed, 249 insertions(+), 195 deletions(-)