Wireshark-commits: [Wireshark-commits] master 7044c61: PacketList: markFrame: remove write-only var
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 13 Apr 2020 10:20:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7044c6101d79292753af84eb358a6c4561dec15e
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

7044c61 by Martin Kaiser (wireshark@xxxxxxxxx):

    PacketList: markFrame: remove write-only variable
    
    The "rows" variable is populated with the indices of all selected rows.
    It seems that rows is never read and can be removed.
    
    (In parallel, there's QModelIndexList frames. This list is used
    when it comes to actually marking the selected packets.)
    
    Change-Id: If2b97a2f5d87fe24717b9ad56444e2a779e0b3fc
    Reviewed-on: https://code.wireshark.org/review/36804
    Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  71f6d94   Qt: don't use a widget if not set.
     add  7044c61   PacketList: markFrame: remove write-only variable


Summary of changes:
 ui/qt/packet_list.cpp | 2 --
 1 file changed, 2 deletions(-)