Wireshark-commits: [Wireshark-commits] master f9fdf32: CSN.1: Optimize update of remaining_bits_len
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 27 Mar 2020 16:38:42 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9fdf327ce8976cbce10a0c547161280616ff7f6
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

f9fdf32 by Pau Espin Pedrol (pespin@xxxxxxxxxxx):

    CSN.1: Optimize update of remaining_bits_len dissecting CSN_UINT_ARRAY
    
    No need to decrement it every loop. Furthermore, when more types are
    supported, same line can be reused.
    
    Change-Id: Ic61c2e839d8dcb0e035172d706978a18b16520df
    Reviewed-on: https://code.wireshark.org/review/36592
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    

Actions performed:

    from  543c55b   CSN.1: verify enough bits present to decode whole CSN_UINT_ARRAY
     add  f9fdf32   CSN.1: Optimize update of remaining_bits_len dissecting CSN_UINT_ARRAY


Summary of changes:
 epan/dissectors/packet-csn1.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)