Wireshark-commits: [Wireshark-commits] master-3.2 8885cd2: NAS-5GS: shift supi_fmt field before tes
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 24 Mar 2020 10:41:04 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8885cd29fdf8136d50dd9454eb34baf0745be447
Submitter: "Pascal Quantin <pascal@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

8885cd2 by Martin Mathieson (martin.mathieson@xxxxxxxxxxxx):

    NAS-5GS: shift supi_fmt field before testing
    
    From cppcheck:
    epan/dissectors/packet-nas_5gs.c:749: style: Mismatching assignment and comparison, comparison 'supi_fmt==1' is always false.
    
    Change-Id: I702f0cae24fd95dc925a87ab3766f2995f3eb759
    Reviewed-on: https://code.wireshark.org/review/36554
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal@xxxxxxxxxxxxx>
    (cherry picked from commit d854143e8fa49aea130a0dfa995fe7466076b7c8)
    Reviewed-on: https://code.wireshark.org/review/36555
    

Actions performed:

    from  706db7f   coap: use correct OSCORE option type
     add  8885cd2   NAS-5GS: shift supi_fmt field before testing


Summary of changes:
 epan/dissectors/packet-nas_5gs.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)