Wireshark-commits: [Wireshark-commits] master d430932: packet-ntlmssp: don't pass 'gbl_nt_password'
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 14 Mar 2020 15:07:21 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d430932b4e144428a1a42ee9e4dd600b978386be
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

d430932 by Stefan Metzmacher (metze@xxxxxxxxx):

    packet-ntlmssp: don't pass 'gbl_nt_password' to create_ntlmssp_v[1|2]_key()
    
    Instead use it directly where needed.
    
    I follow up patch will rename gbl_nt_password to
    ntlmssp_option_nt_password and make that static to packet-ntlmssp.c
    
    Change-Id: Iceb75ebbdb70814cb4a235ad3e8ed5e9ec2be10c
    Signed-off-by: Stefan Metzmacher <metze@xxxxxxxxx>
    Reviewed-on: https://code.wireshark.org/review/36397
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  d947c7d   packet-dcerpc-nt: split out cb_str_postprocess_options()
     add  d430932   packet-ntlmssp: don't pass 'gbl_nt_password' to create_ntlmssp_v[1|2]_key()


Summary of changes:
 epan/dissectors/packet-ntlmssp.c | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)