Wireshark-commits: [Wireshark-commits] master-3.2 acbbbde: gitlab-ci: remove unnecessary jobs, upgr
Date Index · Thread Index · Other Months · All Mailing Lists
Date Prev · Date Next · Thread Prev · Thread Next
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 05 Mar 2020 23:33:50 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=acbbbde899c12173057d1be165e1f973b64848ad
Submitter: "Peter Wu <peter@xxxxxxxxxxxxx>"
Changed: branch: master-3.2
Repository: wireshark

Commits:

acbbbde by Peter Wu (peter@xxxxxxxxxxxxx):

    gitlab-ci: remove unnecessary jobs, upgrade versions
    
    The point of testing multiple compiler versions is to catch bugs that
    only occur in one particular version. After an analysis of 800+ failed
    builds, it appears that a lot of the checks are redundant. Changes:
    
    * Drop GCC 6 and keep GCC 5, Ubuntu 16.04 default GCC is 5.3. Fixes for
      warnings in old compilers: commit 829d2c3752 (GCC 5 + 6), commit
      e451ea0a4d (Clang 5, GCC 4 + 5). Maybe GCC 5 can also be dropped since
      Ubuntu 18.04 is around for a while.
    * Drop clang-nopcap, all errors caught by Clang were also caught by GCC.
      One change caught by gcc-8-nopcap but not Clang: commit 036c3d6bc7.
    * Remove Clang 5: even though it triggers some unique failures, no major
      distro ships with it so remove it.
    * Drop old Clang versions, newer versions catch all warnings from older.
    * Upgrade to Clang 8 which is already installed in the Docker image.
    * Remove EOL Fedora 28 and 29, use latest (31).
    * Remove EOL openSUSE Leap 42.3, keep 15.1 as the latest.
    
    Reduces from 20 jobs (15 build, 5 test) to 10 jobs (7 build, 3 test).
    
    Change-Id: I4a355dd1a90cbbef9525bd63a8544fa3e22369a2
    Reviewed-on: https://code.wireshark.org/review/36281
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit 6bb691189c04a8fd0d618c112290b19ea6d28a0e)
    Reviewed-on: https://code.wireshark.org/review/36304
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  a9ecd94   Qt: Don't hijack Ctrl+C for copy packet list entry as plain text
     add  acbbbde   gitlab-ci: remove unnecessary jobs, upgrade versions


Summary of changes:
 .gitlab-ci.yml | 88 ++++++++++++----------------------------------------------
 1 file changed, 18 insertions(+), 70 deletions(-)